github-actions[bot] commented on PR #23981: URL: https://github.com/apache/datafusion/pull/23981#issuecomment-5177316624
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 110.429s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.037s] (current) Building datafusion v54.1.0 (baseline) Built [ 108.569s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.954s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 221.992s] datafusion Building datafusion-physical-expr v54.1.0 (current) Built [ 28.456s] (current) Parsing datafusion-physical-expr v54.1.0 (current) Parsed [ 0.057s] (current) Building datafusion-physical-expr v54.1.0 (baseline) Built [ 28.798s] (baseline) Parsing datafusion-physical-expr v54.1.0 (baseline) Parsed [ 0.054s] (baseline) Checking datafusion-physical-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.502s] 223 checks: 220 pass, 3 fail, 0 warn, 30 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/inherent_method_missing.ron Failed in: Partitioning::try_to_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-expr/src/partitioning.rs:535 Partitioning::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-expr/src/partitioning.rs:592 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/struct_missing.ron Failed in: struct datafusion_physical_expr::window::WindowEvalContext, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-expr/src/window/window_expr.rs:626 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_parameter_count_changed.ron Failed in: WindowExpr::evaluate_stateful now takes 2 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/window/window_expr.rs:101 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 58.719s] datafusion-physical-expr Building datafusion-physical-plan v54.1.0 (current) Built [ 38.697s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.155s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 37.925s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.154s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.906s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/inherent_method_missing.ron Failed in: ExecutionPlanEncodeCtx::expr_ctx, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-plan/src/proto.rs:227 ExecutionPlanDecodeCtx::decode_child_with_scalar_subquery_results, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-plan/src/proto.rs:265 ExecutionPlanDecodeCtx::expr_ctx, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-plan/src/proto.rs:352 ScalarSubqueryExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/08d5990d561f72852158100722c54d5795e47269/datafusion/physical-plan/src/scalar_subquery.rs:285 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 79.176s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
