timsaucer commented on code in PR #24028:
URL: https://github.com/apache/datafusion/pull/24028#discussion_r3712411790
##########
datafusion/ffi/src/session/mod.rs:
##########
@@ -355,6 +421,21 @@ impl FFI_SessionRef {
session: &(dyn Session + Send + Sync),
runtime: Option<Handle>,
logical_codec: FFI_LogicalExtensionCodec,
+ ) -> Self {
+ let physical_codec = FFI_PhysicalExtensionCodec::new(
+ Arc::new(DefaultPhysicalExtensionCodec {}),
+ runtime.clone(),
+ logical_codec.task_ctx_provider.clone(),
+ );
+ Self::new_with_ffi_codecs(session, runtime, logical_codec,
physical_codec)
+ }
+
+ /// Creates a new [`FFI_SessionRef`] using existing FFI codecs.
+ pub fn new_with_ffi_codecs(
+ session: &(dyn Session + Send + Sync),
Review Comment:
No, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
