adriangbot commented on PR #24086: URL: https://github.com/apache/datafusion/pull/24086#issuecomment-5180976814
π€ Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/24086#issuecomment-5180420975) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) Comparing claude/datafusion-rowgroup-buffering-ec9abc (5ff7af62acc00fbfe33496798fd22245958be41b) to 39d5064 (merge-base) [diff](https://github.com/apache/datafusion/compare/39d50641424dfbc9fadad9cad17619c64d06076b..5ff7af62acc00fbfe33496798fd22245958be41b) <details><summary>Run configuration</summary> ```yaml run benchmark clickbench_partitioned env: DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G" DF_FETCH_BUDGET: "104857600" DF_FETCH_POLICY: "streaming" SIMULATE_LATENCY: "true" ``` </details> <details><summary>CPU Details (lscpu)</summary> ``` Architecture: aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping: r0p1 BogoMIPS: 2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache: 32 MiB (16 instances) L3 cache: 80 MiB (1 instance) NUMA node(s): 1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; __user pointer sanitization Vulnerability Spectre v2: Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` </details> <details><summary>Details</summary> <p> ``` Comparing HEAD and claude_datafusion-rowgroup-buffering-ec9abc -------------------- Benchmark clickbench_partitioned.json -------------------- βββββββββββββ³βββββββββββββ³ββββββββββββββββββββββββββββββββββββββββββββββ³ββββββββββββββββ β Query β HEAD β claude_datafusion-rowgroup-buffering-ec9abc β Change β β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β QQuery 0 β 1.50 ms β 1.23 ms β +1.21x faster β β QQuery 1 β 1876.53 ms β 1871.95 ms β no change β β QQuery 2 β 2169.73 ms β 2199.67 ms β no change β β QQuery 3 β 2108.07 ms β 2158.55 ms β no change β β QQuery 4 β 2307.03 ms β 2317.64 ms β no change β β QQuery 5 β 2361.87 ms β 2387.09 ms β no change β β QQuery 6 β 1.29 ms β 1.26 ms β no change β β QQuery 7 β 1951.63 ms β 1928.45 ms β no change β β QQuery 8 β 2795.76 ms β 2786.89 ms β no change β β QQuery 9 β 2628.08 ms β 2656.69 ms β no change β β QQuery 10 β 2216.50 ms β 2181.54 ms β no change β β QQuery 11 β 2184.73 ms β 2239.07 ms β no change β β QQuery 12 β 2381.40 ms β 2344.64 ms β no change β β QQuery 13 β 2917.46 ms β 2834.02 ms β no change β β QQuery 14 β 2346.84 ms β 2369.32 ms β no change β β QQuery 15 β 2365.18 ms β 2358.14 ms β no change β β QQuery 16 β 3108.76 ms β 3122.35 ms β no change β β QQuery 17 β 2766.53 ms β 2756.51 ms β no change β β QQuery 18 β 3863.28 ms β 3871.49 ms β no change β β QQuery 19 β 1795.43 ms β 1737.85 ms β no change β β QQuery 20 β 2679.46 ms β 2602.96 ms β no change β β QQuery 21 β 2642.79 ms β 2638.26 ms β no change β β QQuery 22 β 3103.29 ms β 3164.13 ms β no change β β QQuery 23 β 4965.33 ms β 4983.70 ms β no change β β QQuery 24 β 468.08 ms β 455.75 ms β no change β β QQuery 25 β 2252.88 ms β 2273.91 ms β no change β β QQuery 26 β 481.74 ms β 467.99 ms β no change β β QQuery 27 β 2679.20 ms β 2718.82 ms β no change β β QQuery 28 β 5193.63 ms β 5126.89 ms β no change β β QQuery 29 β 2184.23 ms β 2157.99 ms β no change β β QQuery 30 β 2461.53 ms β 2493.37 ms β no change β β QQuery 31 β 2628.71 ms β 2661.60 ms β no change β β QQuery 32 β 4485.92 ms β 4488.49 ms β no change β β QQuery 33 β 4142.64 ms β 4266.69 ms β no change β β QQuery 34 β 4276.75 ms β 4266.97 ms β no change β β QQuery 35 β 2416.47 ms β 2377.48 ms β no change β β QQuery 36 β 182.28 ms β 141.24 ms β +1.29x faster β β QQuery 37 β 139.79 ms β 144.59 ms β no change β β QQuery 38 β 146.29 ms β 128.47 ms β +1.14x faster β β QQuery 39 β 233.74 ms β 187.48 ms β +1.25x faster β β QQuery 40 β 117.74 ms β 115.55 ms β no change β β QQuery 41 β 116.38 ms β 115.54 ms β no change β β QQuery 42 β 116.46 ms β 113.79 ms β no change β βββββββββββββ΄βββββββββββββ΄ββββββββββββββββββββββββββββββββββββββββββββββ΄ββββββββββββββββ ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ³βββββββββββββ β Benchmark Summary β β β‘ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β Total Time (HEAD) β 92262.90ms β β Total Time (claude_datafusion-rowgroup-buffering-ec9abc) β 92215.99ms β β Average Time (HEAD) β 2145.65ms β β Average Time (claude_datafusion-rowgroup-buffering-ec9abc) β 2144.56ms β β Queries Faster β 4 β β Queries Slower β 0 β β Queries with No Change β 39 β β Queries with Failure β 0 β ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββ Distribution per query (min / mean Β±stddev / max): Comparing HEAD and claude_datafusion-rowgroup-buffering-ec9abc -------------------- Benchmark clickbench_partitioned.json -------------------- βββββββββββββ³ββββββββββββββββββββββββββββββββββββββββ³ββββββββββββββββββββββββββββββββββββββββββββββ³ββββββββββββββββ β Query β HEAD β claude_datafusion-rowgroup-buffering-ec9abc β Change β β‘ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β QQuery 0 β 1.50 / 4.34 Β±5.49 / 15.31 ms β 1.23 / 3.99 Β±5.40 / 14.79 ms β +1.09x faster β β QQuery 1 β 1876.53 / 1931.75 Β±34.89 / 1970.31 ms β 1871.95 / 1932.13 Β±50.56 / 1992.13 ms β no change β β QQuery 2 β 2169.73 / 2244.70 Β±52.86 / 2303.47 ms β 2199.67 / 2251.67 Β±54.20 / 2329.67 ms β no change β β QQuery 3 β 2108.07 / 2178.05 Β±69.00 / 2297.37 ms β 2158.55 / 2201.83 Β±48.49 / 2291.52 ms β no change β β QQuery 4 β 2307.03 / 2387.04 Β±64.67 / 2472.04 ms β 2317.64 / 2355.94 Β±24.57 / 2394.84 ms β no change β β QQuery 5 β 2361.87 / 2438.28 Β±48.25 / 2501.95 ms β 2387.09 / 2433.25 Β±31.60 / 2477.29 ms β no change β β QQuery 6 β 1.29 / 1.44 Β±0.24 / 1.91 ms β 1.26 / 1.40 Β±0.22 / 1.84 ms β no change β β QQuery 7 β 1951.63 / 2007.20 Β±57.98 / 2107.91 ms β 1928.45 / 2002.86 Β±59.19 / 2064.36 ms β no change β β QQuery 8 β 2795.76 / 2848.53 Β±44.04 / 2914.95 ms β 2786.89 / 2829.82 Β±63.92 / 2956.01 ms β no change β β QQuery 9 β 2628.08 / 2665.03 Β±36.94 / 2716.34 ms β 2656.69 / 2704.53 Β±61.59 / 2821.72 ms β no change β β QQuery 10 β 2216.50 / 2270.87 Β±49.47 / 2363.20 ms β 2181.54 / 2263.25 Β±44.58 / 2312.47 ms β no change β β QQuery 11 β 2184.73 / 2280.23 Β±54.82 / 2344.05 ms β 2239.07 / 2325.28 Β±61.35 / 2401.65 ms β no change β β QQuery 12 β 2381.40 / 2422.00 Β±29.37 / 2450.03 ms β 2344.64 / 2442.68 Β±64.05 / 2547.00 ms β no change β β QQuery 13 β 2917.46 / 2977.03 Β±41.03 / 3030.92 ms β 2834.02 / 2943.65 Β±99.03 / 3083.54 ms β no change β β QQuery 14 β 2346.84 / 2431.45 Β±62.22 / 2506.92 ms β 2369.32 / 2446.25 Β±51.51 / 2520.32 ms β no change β β QQuery 15 β 2365.18 / 2428.05 Β±52.15 / 2498.08 ms β 2358.14 / 2394.53 Β±23.50 / 2431.07 ms β no change β β QQuery 16 β 3108.76 / 3180.85 Β±44.68 / 3228.89 ms β 3122.35 / 3176.54 Β±44.53 / 3234.41 ms β no change β β QQuery 17 β 2766.53 / 2811.51 Β±54.14 / 2903.36 ms β 2756.51 / 2836.77 Β±47.47 / 2891.52 ms β no change β β QQuery 18 β 3863.28 / 3958.35 Β±78.20 / 4091.53 ms β 3871.49 / 3987.17 Β±117.16 / 4157.05 ms β no change β β QQuery 19 β 1795.43 / 1835.85 Β±58.69 / 1950.11 ms β 1737.85 / 1806.38 Β±55.55 / 1903.55 ms β no change β β QQuery 20 β 2679.46 / 2724.70 Β±51.32 / 2816.70 ms β 2602.96 / 2709.80 Β±77.26 / 2821.41 ms β no change β β QQuery 21 β 2642.79 / 2685.00 Β±37.87 / 2747.89 ms β 2638.26 / 2685.91 Β±24.59 / 2709.38 ms β no change β β QQuery 22 β 3103.29 / 3187.33 Β±55.54 / 3262.09 ms β 3164.13 / 3196.01 Β±31.36 / 3249.98 ms β no change β β QQuery 23 β 4965.33 / 5031.19 Β±74.21 / 5173.48 ms β 4983.70 / 5081.21 Β±81.03 / 5204.99 ms β no change β β QQuery 24 β 468.08 / 539.73 Β±52.96 / 596.48 ms β 455.75 / 480.07 Β±18.50 / 504.29 ms β +1.12x faster β β QQuery 25 β 2252.88 / 2294.29 Β±47.10 / 2384.72 ms β 2273.91 / 2313.04 Β±42.66 / 2391.64 ms β no change β β QQuery 26 β 481.74 / 506.39 Β±20.87 / 531.87 ms β 467.99 / 543.78 Β±70.48 / 655.40 ms β 1.07x slower β β QQuery 27 β 2679.20 / 2756.87 Β±45.32 / 2808.06 ms β 2718.82 / 2755.05 Β±31.24 / 2808.93 ms β no change β β QQuery 28 β 5193.63 / 5313.75 Β±96.37 / 5456.72 ms β 5126.89 / 5319.09 Β±134.85 / 5481.01 ms β no change β β QQuery 29 β 2184.23 / 2284.87 Β±88.59 / 2428.28 ms β 2157.99 / 2254.65 Β±75.94 / 2349.44 ms β no change β β QQuery 30 β 2461.53 / 2537.85 Β±88.21 / 2700.86 ms β 2493.37 / 2563.35 Β±59.45 / 2632.93 ms β no change β β QQuery 31 β 2628.71 / 2731.62 Β±66.83 / 2824.61 ms β 2661.60 / 2744.88 Β±81.41 / 2870.35 ms β no change β β QQuery 32 β 4485.92 / 4521.54 Β±34.32 / 4576.07 ms β 4488.49 / 4582.30 Β±62.65 / 4641.22 ms β no change β β QQuery 33 β 4142.64 / 4214.11 Β±73.21 / 4333.89 ms β 4266.69 / 4330.68 Β±65.53 / 4453.23 ms β no change β β QQuery 34 β 4276.75 / 4347.98 Β±69.69 / 4462.41 ms β 4266.97 / 4311.62 Β±59.47 / 4427.85 ms β no change β β QQuery 35 β 2416.47 / 2474.01 Β±37.62 / 2519.16 ms β 2377.48 / 2481.71 Β±76.01 / 2568.09 ms β no change β β QQuery 36 β 182.28 / 217.06 Β±42.74 / 297.87 ms β 141.24 / 212.62 Β±40.13 / 249.82 ms β no change β β QQuery 37 β 139.79 / 187.05 Β±37.86 / 242.25 ms β 144.59 / 194.40 Β±35.51 / 244.31 ms β no change β β QQuery 38 β 146.29 / 191.95 Β±34.11 / 246.55 ms β 128.47 / 191.03 Β±36.45 / 230.00 ms β no change β β QQuery 39 β 233.74 / 268.55 Β±44.23 / 352.80 ms β 187.48 / 280.33 Β±53.50 / 343.53 ms β no change β β QQuery 40 β 117.74 / 169.55 Β±35.51 / 218.71 ms β 115.55 / 170.53 Β±37.17 / 219.80 ms β no change β β QQuery 41 β 116.38 / 167.95 Β±35.56 / 217.01 ms β 115.54 / 168.33 Β±35.64 / 215.90 ms β no change β β QQuery 42 β 116.46 / 166.74 Β±35.38 / 215.83 ms β 113.79 / 168.23 Β±35.58 / 214.84 ms β no change β βββββββββββββ΄ββββββββββββββββββββββββββββββββββββββββ΄ββββββββββββββββββββββββββββββββββββββββββββββ΄ββββββββββββββββ ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ³βββββββββββββ β Benchmark Summary β β β‘ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β Total Time (HEAD) β 94822.64ms β β Total Time (claude_datafusion-rowgroup-buffering-ec9abc) β 95078.52ms β β Average Time (HEAD) β 2205.18ms β β Average Time (claude_datafusion-rowgroup-buffering-ec9abc) β 2211.13ms β β Queries Faster β 2 β β Queries Slower β 1 β β Queries with No Change β 40 β β Queries with Failure β 0 β ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββ ``` </p> </details> <details><summary>Memory Pool Peaks</summary> Peak `MemoryPool` reservation per query β what DataFusion's accounting believes it reserved. Recorded only when the benchmark runs with `DATAFUSION_RUNTIME_MEMORY_LIMIT` set. Base: `39d5064 (merge-base)` | Changed: `claude/datafusion-rowgroup-buffering-ec9abc` **`clickbench_partitioned`** | Query | Base | Changed | Change | | --- | --- | --- | --- | | Query 0 | 0 B | 0 B | 0.0% | | Query 1 | 0 B | 0 B | 0.0% | | Query 2 | 0 B | 0 B | 0.0% | | Query 3 | 0 B | 0 B | 0.0% | | Query 4 | 1.3 GiB | 1.3 GiB | -4.1% | | Query 5 | 1.6 GiB | 1.6 GiB | -0.0% | | Query 6 | 0 B | 0 B | 0.0% | | Query 7 | 40.3 MiB | 40.0 MiB | -0.8% | | Query 8 | 1.2 GiB | 1.2 GiB | +0.0% | | Query 9 | 677.5 MiB | 719.5 MiB | +6.2% | | Query 10 | 145.9 MiB | 144.6 MiB | -0.9% | | Query 11 | 154.1 MiB | 157.2 MiB | +2.0% | | Query 12 | 1.7 GiB | 1.7 GiB | -0.8% | | Query 13 | 1.7 GiB | 1.7 GiB | -2.7% | | Query 14 | 1.8 GiB | 1.8 GiB | +0.9% | | Query 15 | 1.8 GiB | 1.7 GiB | -1.0% | | Query 16 | 2.0 GiB | 2.0 GiB | +0.8% | | Query 17 | 2.0 GiB | 2.0 GiB | -3.3% | | Query 18 | 2.2 GiB | 2.3 GiB | +2.0% | | Query 19 | 0 B | 0 B | 0.0% | | Query 20 | 0 B | 0 B | 0.0% | | Query 21 | 3.6 MiB | 3.6 MiB | -0.1% | | Query 22 | 4.2 MiB | 4.2 MiB | -0.5% | | Query 23 | 27.1 MiB | 26.4 MiB | -2.6% | | Query 24 | 59.2 MiB | 54.1 MiB | -8.6% | | Query 25 | 173.2 MiB | 172.8 MiB | -0.3% | | Query 26 | 56.2 MiB | 55.0 MiB | -2.2% | | Query 27 | 2.4 MiB | 2.4 MiB | +0.0% | | Query 28 | 2.0 GiB | 2.0 GiB | -0.7% | | Query 29 | 0 B | 0 B | 0.0% | | Query 30 | 879.7 MiB | 902.6 MiB | +2.6% | | Query 31 | 1.4 GiB | 1.4 GiB | -0.1% | | Query 32 | 1.4 GiB | 1.4 GiB | +0.2% | | Query 33 | 2.2 GiB | 2.2 GiB | +1.6% | | Query 34 | 2.2 GiB | 2.2 GiB | -0.9% | | Query 35 | 905.9 MiB | 916.0 MiB | +1.1% | | Query 36 | 139.8 MiB | 140.4 MiB | +0.4% | | Query 37 | 6.9 MiB | 7.2 MiB | +4.7% | | Query 38 | 5.1 MiB | 6.2 MiB | +22.4% | | Query 39 | 327.7 MiB | 331.5 MiB | +1.2% | | Query 40 | 2.0 MiB | 2.2 MiB | +8.4% | | Query 41 | 2.9 MiB | 3.0 MiB | +3.6% | | Query 42 | 1.8 MiB | 1.9 MiB | +4.4% | **Pool accounting vs. process RSS** Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it. | Benchmark | Side | Max pool peak | Peak RSS | Gap | RSS / pool | | --- | --- | --- | --- | --- | --- | | clickbench_partitioned | base (`39d5064 (merge-base)`) | 2.2 GiB | 7.4 GiB | 5.2 GiB | 3.3Γ | | clickbench_partitioned | changed (`claude/datafusion-rowgroup-buffering-ec9abc`) | 2.3 GiB | 7.3 GiB | 5.0 GiB | 3.2Γ | </details> <details><summary>Resource Usage</summary> **clickbench_partitioned β base (merge-base)** | Metric | Value | |--------|-------| | Wall time | 480.1s | | Peak memory | 7.4 GiB | | Avg memory | 3.4 GiB | | CPU user | 1426.6s | | CPU sys | 175.4s | | Peak spill | 0 B | **clickbench_partitioned β branch** | Metric | Value | |--------|-------| | Wall time | 480.1s | | Peak memory | 7.3 GiB | | Avg memory | 3.5 GiB | | CPU user | 1428.8s | | CPU sys | 174.7s | | Peak spill | 0 B | </details> --- [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
