fyrsta7 opened a new pull request, #2426: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2426
## Summary Fixes #2421 by rejecting invalid numeric underscore separators for dialects that support underscores in numeric literals. ## Details Numeric separators should appear between digits. This keeps valid literals such as `10_000` and `1_000.123_456`, while rejecting trailing, consecutive, and decimal-point-adjacent underscores such as `10_00_`, `10___0`, `1_000.123_`, and `1._000`. The change adds coverage at both the tokenizer and parser test levels. ## Validation - `git diff --check` - `cargo fmt --all --check` - `cargo test tokenize_numeric_literal_underscore -- --nocapture` - `cargo test parse_numeric_literal_underscore --test sqlparser_common -- --nocapture` - `cargo test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
