andygrove commented on code in PR #5267:
URL: https://github.com/apache/datafusion-comet/pull/5267#discussion_r3720744735
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -258,6 +258,8 @@ object CometConcat
with CometTypeShim
with CodegenDispatchFallback {
private val unsupportedReason = "CONCAT supports only string input
parameters"
+ private val binaryToStringCastReason =
+ "CONCAT over BinaryType-to-StringType casts requires Spark's
byte-preserving semantics"
Review Comment:
Shouldn't this logic apply to all cast-binary-to-string, not just when
called from concat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
