BharatDeva opened a new pull request, #1667:
URL: https://github.com/apache/datafusion-python/pull/1667
# Which issue does this PR close?
Closes #552.
# Rationale for this change
Issue #552 tracks replacing remaining `todo!()` calls with explicit errors.
The only remaining `todo!()` was in `PyGetIndexedField::key`, where unsupported
list-index and list-range field access could panic instead of returning a
Python error.
# What changes are included in this PR?
This updates `PyGetIndexedField::key` to keep returning the struct field key
for `NamedStructField`, and to return the existing unsupported-variant error
for list index and list range access.
# Are there any user-facing changes?
No API change is intended. This only replaces an internal panic path with an
explicit Python error for unsupported field access forms.
# Testing
- `cargo fmt --check`
- `wsl bash -lc "cd
/mnt/c/Users/bhara/OneDrive/Desktop/Python/datafusion-python && cargo check -p
datafusion-python"`
- `rg -n "todo!\\(" crates/core/src -g "*.rs"` returned no matches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
