github-actions[bot] commented on PR #24108: URL: https://github.com/apache/datafusion/pull/24108#issuecomment-5194770944
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource-parquet v54.1.0 (current) Built [ 54.345s] (current) Parsing datafusion-datasource-parquet v54.1.0 (current) Parsed [ 0.033s] (current) Building datafusion-datasource-parquet v54.1.0 (baseline) Built [ 46.133s] (baseline) Parsing datafusion-datasource-parquet v54.1.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.229s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 102.385s] datafusion-datasource-parquet Building datafusion-ffi v54.1.0 (current) Built [ 61.580s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.067s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 60.746s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.066s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.340s] 223 checks: 217 pass, 5 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/constructible_struct_adds_field.ron Failed in: field ForeignLibraryModule.create_query_planner in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:125 field ForeignLibraryModule.create_extension_node_query_planner in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:133 field ForeignLibraryModule.create_session_planning_table in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:138 field FFI_CatalogProviderList.codecs in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/catalog_provider_list.rs:50 field FFI_SchemaProvider.codecs in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/schema_provider.rs:66 field FFI_CatalogProvider.codecs in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/catalog_provider.rs:59 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/inherent_method_missing.ron Failed in: FFI_CatalogProviderList::new_with_ffi_codec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/catalog_provider_list.rs:210 FFI_TableFunction::new_with_ffi_codec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/udtf.rs:221 FFI_SchemaProvider::new_with_ffi_codec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/schema_provider.rs:257 FFI_TableProvider::new_with_ffi_codec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/table_provider.rs:405 FFI_TableProviderFactory::new_with_ffi_codec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/table_provider_factory.rs:116 FFI_CatalogProvider::new_with_ffi_codec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/catalog_provider.rs:247 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_ffi::catalog_provider_list::FFI_CatalogProviderList::new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/catalog_provider_list.rs:194, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/catalog_provider_list.rs:187 datafusion_ffi::udtf::FFI_TableFunction::new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/udtf.rs:203, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udtf.rs:199 datafusion_ffi::schema_provider::FFI_SchemaProvider::new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/schema_provider.rs:240, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/schema_provider.rs:235 datafusion_ffi::table_provider::FFI_TableProvider::new takes 5 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/table_provider.rs:382, but now takes 4 parameters in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/table_provider.rs:386 datafusion_ffi::table_provider_factory::FFI_TableProviderFactory::new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/table_provider_factory.rs:99, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/table_provider_factory.rs:101 datafusion_ffi::catalog_provider::FFI_CatalogProvider::new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/catalog_provider.rs:230, but now takes 3 parameters in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/catalog_provider.rs:223 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/struct_pub_field_missing.ron Failed in: field task_ctx_provider of struct FFI_LogicalExtensionCodec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/proto/logical_extension_codec.rs:102 field logical_codec of struct FFI_CatalogProviderList, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/catalog_provider_list.rs:52 field logical_codec of struct FFI_TableFunction, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/udtf.rs:66 field logical_codec of struct FFI_SchemaProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/schema_provider.rs:68 field logical_codec of struct FFI_TableProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/table_provider.rs:143 field logical_codec of struct FFI_CatalogProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d61bae2d1d21781ca2b1344d47398aba1cbb9276/datafusion/ffi/src/catalog_provider.rs:61 --- failure struct_pub_field_now_doc_hidden: pub struct field is now #[doc(hidden)] --- Description: A pub field of a pub struct is now marked #[doc(hidden)] and is no longer part of the public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/struct_pub_field_now_doc_hidden.ron Failed in: field FFI_LogicalExtensionCodec.task_ctx_provider in file /home/runner/work/datafusion/datafusion/datafusion/ffi/src/proto/logical_extension_codec.rs:54 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: ForeignLibraryModule.version moved from position 19 to 22, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:141 ForeignLibraryModule.create_first_value_udaf moved from position 20 to 23, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:144 Summary semver requires new major version: 5 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 124.988s] datafusion-ffi ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
