adriangb commented on PR #24090: URL: https://github.com/apache/datafusion/pull/24090#issuecomment-5195626057
> > I spent some time stress-testing this (mutation testing, randomised differential testing against the arrow-rs reader, and benchmarks on wide schemas) and found one correctness bug plus a few smaller things. I've opened [mbutrovich#1](https://github.com/mbutrovich/datafusion/pull/1) against your branch with fixes and tests — fold it in however you like. > > Does it address the earlier review comments? It addresses the coverage aspect, it doesn't implement this for filter pushdown, I think we should defer that to followups. I think if we merge that into here we can then merge this into main and track a couple of followups, namely: - Getting this optimization to work for filter pushdown - Taking the union of fields from a cast instead of reading the whole column -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
