adriangb commented on code in PR #23752:
URL: https://github.com/apache/datafusion/pull/23752#discussion_r3723033676
##########
datafusion/datasource/src/sink.rs:
##########
@@ -145,6 +161,39 @@ impl DataSinkExec {
&self.sort_order
}
+ /// Encode the optional sink ordering for a protobuf plan node.
+ #[cfg(feature = "proto")]
+ pub fn encode_sort_order(
+ &self,
+ ctx: &datafusion_physical_plan::proto::ExecutionPlanEncodeCtx<'_>,
+ ) ->
Result<Option<datafusion_proto_models::protobuf::PhysicalSortExprNodeCollection>>
+ {
+ use datafusion_physical_expr::PhysicalSortExpr;
+ use datafusion_proto_models::protobuf;
+
+ self.sort_order
+ .as_ref()
+ .map(|requirements| {
+ requirements
+ .iter()
+ .map(|requirement| {
+ let expr: PhysicalSortExpr =
requirement.to_owned().into();
+ Ok(protobuf::PhysicalSortExprNode {
+ expr: Some(Box::new(ctx.encode_expr(&expr.expr)?)),
+ asc: !expr.options.descending,
+ nulls_first: expr.options.nulls_first,
+ })
+ })
+ .collect::<Result<Vec<_>>>()
+ .map(|physical_sort_expr_nodes| {
+ protobuf::PhysicalSortExprNodeCollection {
+ physical_sort_expr_nodes,
+ }
+ })
+ })
Review Comment:
This duplicates the logic in
https://github.com/apache/datafusion/blob/3e3a92de29ed3d454e72c7bade6328508b6098c6/datafusion/proto/src/physical_plan/mod.rs#L2586-L2608
Can we replace the version linked above with
`exec.encode_sort_order(&ExecutionPlanEncodeCtx::new(&encoder))?`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
