kosiew commented on code in PR #1662:
URL:
https://github.com/apache/datafusion-python/pull/1662#discussion_r3725784463
##########
python/tests/test_expr.py:
##########
@@ -68,6 +70,17 @@ def test_ctx():
return ctx
+def test_create_external_table_location_is_deprecated():
Review Comment:
Nice to see the deprecated shim covered. One thought: since this test calls
the shim with a `MagicMock`, it does not verify that
`CreateExternalTable.locations()` is actually bound to the upstream `locations`
field.
Would it make sense to build a real `CREATE EXTERNAL TABLE` logical plan
instead and assert both `locations()` and the deprecated `location()` on the
resulting variant? That would exercise the Rust/Python boundary introduced by
this upgrade and give a bit more confidence that the binding is wired up
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
