kosiew commented on code in PR #23188:
URL: https://github.com/apache/datafusion/pull/23188#discussion_r3725883661
##########
datafusion/proto-models/proto/datafusion.proto:
##########
@@ -1050,6 +1050,8 @@ message PhysicalExprNode {
PhysicalHigherOrderUdfNode higher_order_udf = 24;
PhysicalLambdaExprNode lambda = 25;
PhysicalLambdaVariableExprNode lambda_variable = 26;
+
+ PhysicalSqlSimilarToPatternNode sql_similar_to_pattern = 27;
Review Comment:
Thanks for adding the protobuf support for dynamic `SIMILAR TO` patterns.
There is still a release compatibility issue here.
Adding this `oneof` arm generates the public exhaustive Rust enum variant
`PhysicalExprNode::ExprType::SqlSimilarToPattern`. Downstream code that
exhaustively matches the enum and currently compiles against
`datafusion-proto-models 54.1.0` will stop compiling, while this branch still
publishes the crate as version `54.1.0`. This appears to be the source of the
unresolved `cargo-semver-checks` failure.
Could we avoid exposing the new generated variant in this release, perhaps
by keeping the previous dynamic-pattern representation and deferring
`SqlSimilarToPattern` protobuf support? Otherwise, this needs the appropriate
compatible release-version and API strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
