lyne7-sc commented on PR #24097:
URL: https://github.com/apache/datafusion/pull/24097#issuecomment-5201624721
@neilconway Thanks for pointing this out. I added two benchmarks for the
scalar and grouped accumulators to approximate AggregateExec per-batch
memory-accounting behavior. Each benchmark processes 32 batches, with memory
accounting performed after every batch. The comparison against main is shown
below:
```
group main
pr-accounting-final
----- ---
-------------------
array_agg i64 groups update_batch with memory accounting 1.08
425.4±20.54µs ? ?/sec 1.00 394.0±20.74µs ? ?/sec
array_agg i64 update_batch with memory accounting 26.47
55.9±0.84µs ? ?/sec 1.00 2.1±0.10µs ? ?/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
