JSOD11 commented on code in PR #24115:
URL: https://github.com/apache/datafusion/pull/24115#discussion_r3729897485
##########
datafusion/spark/src/function/string/format_string.rs:
##########
@@ -2268,6 +2214,44 @@ impl ConversionSpecifier {
TimeFormat::CLower => Ok(dt.format("%a %b %d %H:%M:%S UTC
%Y").to_string()),
}
}
+
+ fn write_numeric_parts(
Review Comment:
Thanks for the review!
Good idea, just added these tests. Let me know if the change looks like what
you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
