notfilippo commented on PR #24144: URL: https://github.com/apache/datafusion/pull/24144#issuecomment-5206856256
> lgtm! Clean fix with a nicely scoped unit test. > > There's a few places where we construct the grouping ID column via `Expr::Column(Column::from_name(Aggregate::INTERNAL_GROUPING_ID))`, which maybe would benefit from centralizing into a helper, but I think it's marginal. I can follow up with a new issue and a new PR, I think it would definitely help a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
