Smallfu666 commented on PR #5162: URL: https://github.com/apache/datafusion-comet/pull/5162#issuecomment-5208053004
Thanks. I addressed the remaining feedback. `checkOverflow` now takes explicit Spark and Comet substrings, with the version-specific Spark message handled in one `sparkOverflowMsg` helper. The float cases now use `checkSparkAnswerAndOperator`, since float negation does not overflow. I also removed the comments that described the previous implementation. The native tests and `CometExpressionSuite` pass locally on Spark 3.5 and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
