avantgardnerio commented on PR #2204:
URL: 
https://github.com/apache/datafusion-ballista/pull/2204#issuecomment-5209167496

   @andygrove @phillipleblanc we now have our first real (EKS) benchmark 
results for halo-based parallel windows. h2o is kind of a worst case, because 
as the data keeps getting bigger, the value range stays the same, so the cost 
of duplicated halos starts to dominate:
   
   ```
     
┌─────┬─────────────┬──────────────────────────┬─────────────────────────────────────┐
     │  K  │ Theoretical │ With #2204 range-pruning │           Without (today) 
          │
     
├─────┼─────────────┼──────────────────────────┼─────────────────────────────────────┤
     │ 8   │ 6.5×        │ 6.5×                     │ ~4.7× observed            
          │
     
├─────┼─────────────┼──────────────────────────┼─────────────────────────────────────┤
     │ 16  │ 10.8×       │ ~10×                     │ probably ~6× (I/O amp 
bites harder) │
     
├─────┼─────────────┼──────────────────────────┼─────────────────────────────────────┤
     │ 32  │ 16.3×       │ ~14×                     │ probably ~7× (I/O amp 
dominates)    │
     
├─────┼─────────────┼──────────────────────────┼─────────────────────────────────────┤
     │ 100 │ ~25×        │ ~20×                     │ collapses (300% halo)     
          │
     
└─────┴─────────────┴──────────────────────────┴─────────────────────────────────────┘
   ```
   
   but even if we cap it at 8 or 32 cores, 5-15x wins seem worthwhile? (not to 
mention OOM reduction). I promised "this time" I was just going to deliver a PR 
with e2e abilities, but TBH it's grown too big again. Given that it now proves 
it works, you guys cool with me splitting off lots of little supporting PRs 
from this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to