akshaychitneni commented on code in PR #2240:
URL:
https://github.com/apache/datafusion-ballista/pull/2240#discussion_r3736772072
##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -309,7 +315,9 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerState<T,
// It's OK to remove executor aggressively,
// since if the executor is in healthy state, it
will be registered again.
- state.remove_executor(&executor_id,
Some(err_msg)).await;
+ state
Review Comment:
@andygrove @milenkovicm probably this was missed. Do you agree to update
default value and add validation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
