andygrove opened a new issue, #5306: URL: https://github.com/apache/datafusion-comet/issues/5306
### What is the problem the feature request solves? Comet now has two experimental write features under two different config namespaces: | Config | Added by | | --- | --- | | `spark.comet.write.iceberg.splitOperator.enabled` | #4658 | | `spark.comet.parquet.write.enabled` | native Parquet writes | One is `spark.comet.write.<format>.<feature>`, the other `spark.comet.<format>.write.<feature>`. Both are `CATEGORY_TESTING` and default to false, so nothing user-facing is broken yet — which makes this the cheap moment to pick one shape, before either graduates and the key has to be kept as a deprecated alias. Worth settling alongside it: the operator opt-in for native Parquet writes is `spark.comet.operator.WriteFilesExec.allowIncompatible` (with `spark.comet.operator.DataWritingCommandExec.allowIncompatible` retained as an alternative), so a user enabling native Parquet writes currently sets two configs while the Iceberg feature needs one. ### Describe the potential solution Pick one namespace and move the other with `withAlternative`, per the rename checklist in `docs/source/contributor-guide/config_conventions.md`. `spark.comet.write.*` reads better as writes grow more formats and features, but either is fine as long as it is one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
