adriangb commented on PR #24167: URL: https://github.com/apache/datafusion/pull/24167#issuecomment-5219977103
> Thanks @adriangb. This looks good overall. The PR description says that the changes in this PR are tested by existing roundtrip tests, but I'm not sure that those are comprehensive? For example, I don't see a roundtrip test for `SortPreservingMergeExec` whcih is updated in this PR. Good point. I'll check and add tests that are missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
