peterxcli commented on PR #5169: URL: https://github.com/apache/datafusion-comet/pull/5169#issuecomment-5227552724
@andygrove thanks for another round of review, addressed your review. PTAL! > 1. Compatibility guide still says these paths raise `CometNativeException` Updated `compatibility/index.md` to retain only the remaining wide-decimal message-value divergence tracked by #5211. > 2. Query-context assertions never compare against Spark Changed both regressions to compare Spark and Comet fragments exactly in `CometExpressionSuite.scala`. This exposed and fixed a serializer bug in `QueryPlanSerde.scala`: passthrough `Alias` serialization was overwriting the child’s precise context with the full SQL statement. > 3. Add `arithmeticError` to #5223 https://github.com/apache/datafusion-comet/issues/5223: added CometExpressionSuite.arithmeticError; inventory now says six call sites across five suites. > 4. Document `MathContext(38, HALF_UP)` in #5211 https://github.com/apache/datafusion-comet/issues/5211: added Spark’s MathContext(38, HALF_UP) rounding behavior and the non-zero-low-digit implication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
