jayshrivastava commented on PR #24018: URL: https://github.com/apache/datafusion/pull/24018#issuecomment-5229043243
Addressed comments. I have to run but here are the remaining open threads of work/discussion 1. Fix conflicts - I will do later 2. Small discussion about if expressions in the `properties()` should be traversed by `apply_expressions`. I think they should not. https://github.com/apache/datafusion/pull/24018#discussion_r3742124344 3. The [AsRef](https://github.com/apache/datafusion/pull/24018#pullrequestreview-4886401724) follow up. I actually wouldn't mind doing this in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
