alamb commented on PR #11942: URL: https://github.com/apache/datafusion/pull/11942#issuecomment-2289928000
Filed > > > Looks good to me @Lordworms and @Omega359 > > > An epic journey of macros 🚀 > > > I can't help but think this function could be made much faster by using a StringBuilder rather than creating a bunch of `String`s which are then copied. > > > However, that could be some future pR > > > > > > @Omega359's PR here is a pretty good example of how to do this #11987 > > Sure, I'll add a PR for it tomorrow. Filed https://github.com/apache/datafusion/issues/11997 to track -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
