Smallfu666 commented on issue #5071: URL: https://github.com/apache/datafusion-comet/issues/5071#issuecomment-5236993341
I took another look at #5071 after #5162 landed. It looks like item 4 is fixed, but a few of the original issues are still present on curent main: * `Abs` still uses Arrow/Rust type names for overflow errors, e.g. `Int64 overflow` instead of Spark's `long overflow` (item 5). * Int64 arithmetic can still report `integer overflow` instead of `long overflow` (item 2). * The `try_add` / `try_sub` / `try_mul` suggestions are still missing (item 3). I also rechecked item 6 and that one seems to be fine. Would you prefer to reopen #5071 for the remaining items, or track them separately as smaller issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
