alamb commented on code in PR #11973:
URL: https://github.com/apache/datafusion/pull/11973#discussion_r1717585952
##########
datafusion/functions/src/unicode/reverse.rs:
##########
@@ -95,59 +104,58 @@ pub fn reverse<T: OffsetSizeTrait>(args: &[ArrayRef]) ->
Result<ArrayRef> {
#[cfg(test)]
mod tests {
- use arrow::array::{Array, StringArray};
- use arrow::datatypes::DataType::Utf8;
+ use arrow::array::{Array, LargeStringArray, StringArray};
+ use arrow::datatypes::DataType::{LargeUtf8, Utf8};
use datafusion_common::{Result, ScalarValue};
use datafusion_expr::{ColumnarValue, ScalarUDFImpl};
use crate::unicode::reverse::ReverseFunc;
use crate::utils::test::test_function;
+ macro_rules! test_reverse {
Review Comment:
yeah this testing pattern is somewhat common in the string functions
I happen to like .slt in general, but I know that is not for everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
