jayshrivastava commented on PR #24018: URL: https://github.com/apache/datafusion/pull/24018#issuecomment-5241957629
@alamb Not urgent, but I tried implementing the refactor [here](https://github.com/apache/datafusion/pull/24226/changes#r3750579635). `AsRef<Arc<dyn PhysicalExpr>>` isn't implemented for `Arc<dyn PhysicalExpr>` surprisingly, so we cannot cleanly do the refactor you mentioned. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
