LiaCastaneda commented on code in PR #24162:
URL: https://github.com/apache/datafusion/pull/24162#discussion_r3751323217
##########
datafusion/expr/src/higher_order_function.rs:
##########
@@ -257,26 +270,49 @@ pub struct LambdaArgument {
}
impl LambdaArgument {
+ /// Build a [`LambdaArgument`] for a lambda whose body references the
+ /// subset of `params` named in `used_params`.
+ ///
+ /// [`Self::evaluate`] only materialises the closures whose parameter name
+ /// appears in `used_params`, preserving the original declaration order of
+ /// `params`. Unused declared parameters therefore leave no slot in the
+ /// merged batch, so the body's compressed column indices line up directly
+ /// with the columns the evaluator built.
+ ///
+ /// Callers with a `LambdaExpr` in hand should pass `lambda.used_params()`;
+ /// that method already computes the exact set required here (with
+ /// nested-lambda shadow tracking).
Review Comment:
yeah, I read through it and didn't find it irrelevant but its true it can be
simplified since it only talks about the `params` param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
