github-actions[bot] commented on PR #24233: URL: https://github.com/apache/datafusion/pull/24233#issuecomment-5246194396
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource v54.1.0 (current) Built [ 54.421s] (current) Parsing datafusion-datasource v54.1.0 (current) Parsed [ 0.033s] (current) Building datafusion-datasource v54.1.0 (baseline) Built [ 43.365s] (baseline) Parsing datafusion-datasource v54.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.240s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 99.334s] datafusion-datasource Building datafusion-datasource-csv v54.1.0 (current) Built [ 44.179s] (current) Parsing datafusion-datasource-csv v54.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-csv v54.1.0 (baseline) Built [ 44.677s] (baseline) Parsing datafusion-datasource-csv v54.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-csv v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.101s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 89.953s] datafusion-datasource-csv Building datafusion-datasource-json v54.1.0 (current) Built [ 45.668s] (current) Parsing datafusion-datasource-json v54.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-datasource-json v54.1.0 (baseline) Built [ 45.431s] (baseline) Parsing datafusion-datasource-json v54.1.0 (baseline) Parsed [ 0.014s] (baseline) Checking datafusion-datasource-json v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.096s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 92.247s] datafusion-datasource-json Building datafusion-proto v54.1.0 (current) Built [ 64.295s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 63.299s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.248s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 129.264s] datafusion-proto Building datafusion-proto-models v54.1.0 (current) Built [ 25.446s] (current) Parsing datafusion-proto-models v54.1.0 (current) Parsed [ 0.130s] (current) Building datafusion-proto-models v54.1.0 (baseline) Built [ 25.371s] (baseline) Parsing datafusion-proto-models v54.1.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-proto-models v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.815s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/constructible_struct_adds_field.ron Failed in: field JsonScanExecNode.newline_delimited in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1993 field JsonScanExecNode.newline_delimited in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1993 field FileScanExecConf.file_compression_type in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1939 field FileScanExecConf.file_compression_type in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1939 field CsvScanExecNode.terminator in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1968 field CsvScanExecNode.terminator in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1968 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 53.907s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
