alamb opened a new issue, #24268: URL: https://github.com/apache/datafusion/issues/24268
### Is your feature request related to a problem or challenge? ## Background When running a query like `SELECT ... GROUP BY x, y` the DataFusion grouping operator computes / stores the group keys using an instance of the [`GroupValuesColumn`](https://docs.rs/datafusion/latest/datafusion/physical_plan/aggregates/group_values/multi_group_by/struct.GroupValuesColumn.html) trait. This trait is a column-wise provides type-specific specializations under [`multi_group_by`](https://github.com/apache/datafusion/blob/1b27f348c97c6eb65d922cb1a208465a2f109311/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs#L1-L0) If any one of the group by keys does not have a specialization of `GroupValuesColumn` DataFusion falls back to the general, but slower byte-encoded [`GroupValuesRows`](https://github.com/apache/datafusion/blob/68d587468073c1fc84ffe00db66f35d506dcc828/datafusion/physical-plan/src/aggregates/group_values/row.rs#L46-L45). ## Definition of Done This EPIC tracks **completing the GroupValuesColumn type coverage** so that [`GroupValuesRows`](https://github.com/apache/datafusion/blob/68d587468073c1fc84ffe00db66f35d506dcc828/datafusion/physical-plan/src/aggregates/group_values/row.rs#L46-L45) can be removed ## Subtasks - [ ] #22682 — `FixedSizeList<primitive>`, `List<T>`, `LargeList<T>`, `Struct<...>` with recursive children. In flight via PR #22706 (split into 5 stacked PRs per maintainer request). ### Describe the solution you'd like _No response_ ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
