jayzhan211 commented on code in PR #11978: URL: https://github.com/apache/datafusion/pull/11978#discussion_r1717989216
########## datafusion/core/src/datasource/physical_plan/file_scan_config.rs: ########## @@ -445,30 +410,7 @@ impl PartitionColumnProjector { "Invalid partitioning found on disk".to_string(), ))?; - let mut partition_value = Cow::Borrowed(p_value); - - // check if user forgot to dict-encode the partition value - let field = self.projected_schema.field(sidx); Review Comment: I check the `field.data_type()` and got the value type (Utf8) but not Dictionary. I'm not sure why, but I expect Dict is preserved at this point 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org