github-actions[bot] commented on PR #24269: URL: https://github.com/apache/datafusion/pull/24269#issuecomment-5254566673
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-proto v54.1.0 (current) Built [ 71.752s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 62.213s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.207s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron Failed in: method try_into_explain_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1287 method try_into_projection_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1305 method try_into_filter_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1332 method try_into_csv_scan_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1353 method try_into_json_scan_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1374 method try_into_arrow_scan_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1395 method try_into_parquet_scan_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1417 method try_into_avro_scan_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1447 method try_into_memory_scan_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1476 method try_into_coalesce_batches_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1497 method try_into_merge_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1524 method try_into_repartition_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1545 method try_into_global_limit_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1568 method try_into_local_limit_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1591 method try_into_window_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1614 method try_into_aggregate_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1637 method try_into_hash_join_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1660 method try_into_symmetric_hash_join_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1683 method try_into_union_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1706 method try_into_interleave_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1727 method try_into_cross_join_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1748 method try_into_empty_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1771 method try_into_placeholder_row_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1792 method try_into_sort_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1815 method try_into_sort_preserving_merge_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1836 method try_into_nested_loop_join_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1881 method try_into_analyze_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1904 method try_into_json_sink_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1922 method try_into_csv_sink_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1943 method try_into_parquet_sink_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1965 method try_into_unnest_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:1993 method try_into_sort_join of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2020 method try_into_cooperative_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2116 method try_into_async_func_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2139 method try_into_buffer_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2162 method try_into_scalar_subquery_physical_plan of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2183 method try_from_explain_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2206 method try_from_projection_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2225 method try_from_analyze_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2244 method try_from_filter_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2263 method try_from_global_limit_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2281 method try_from_local_limit_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2300 method try_from_hash_join_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2319 method try_from_symmetric_hash_join_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2337 method try_from_sort_merge_join_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2356 method try_from_cross_join_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2375 method try_from_aggregate_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2393 method try_from_empty_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2411 method try_from_placeholder_row_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2430 method try_from_coalesce_batches_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2453 method try_from_data_source_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2472 method try_from_coalesce_partitions_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2489 method try_from_repartition_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2508 method try_from_sort_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2527 method try_from_union_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2545 method try_from_interleave_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2564 method try_from_sort_preserving_merge_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2583 method try_from_nested_loop_join_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2602 method try_from_window_agg_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2621 method try_from_bounded_window_agg_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2639 method try_from_data_sink_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2658 method try_from_unnest_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2675 method try_from_cooperative_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2693 method try_from_async_func_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2835 method try_from_buffer_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2853 method try_from_scalar_subquery_exec of trait PhysicalPlanNodeExt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/b231ded26fa2f210809267db52d571202113b3af/datafusion/proto/src/physical_plan/mod.rs:2871 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 136.408s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
