timsaucer commented on code in PR #24205:
URL: https://github.com/apache/datafusion/pull/24205#discussion_r3760779841
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -688,3 +688,129 @@ pub fn statistics_from_parquet_meta_calc(
) -> Result<Statistics> {
DFParquetMetadata::statistics_from_parquet_metadata(metadata,
&table_schema)
}
+
+#[cfg(feature = "proto")]
+use datafusion_proto_models::protobuf::{self, parquet_column_options,
parquet_options};
Review Comment:
nit: generally use statements should go at the top of the file to make it
easy to find.
##########
datafusion/proto-models/Cargo.toml:
##########
@@ -45,6 +45,7 @@ default = []
json = ["serde", "pbjson", "datafusion-proto-common/json"]
[dependencies]
+datafusion-common = { workspace = true }
Review Comment:
I think we need an update to the readme in this folder. This dependency
makes it slightly out of date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
