akshaychitneni commented on code in PR #2279:
URL:
https://github.com/apache/datafusion-ballista/pull/2279#discussion_r3761627730
##########
ballista/scheduler/src/config.rs:
##########
@@ -667,7 +662,12 @@ impl TryFrom<Config> for SchedulerConfig {
executor_timeout_seconds: opt.executor_timeout_seconds,
expire_dead_executor_interval_seconds: opt
.expire_dead_executor_interval_seconds,
- no_executors_grace_period_seconds:
opt.no_executors_grace_period_seconds,
+ // Default to the executor-liveness timeout when unset, so the
grace
+ // is always >= the executor heartbeat interval and a transiently
+ // removed but healthy executor can re-register before it elapses.
+ no_executors_grace_period_seconds: opt
+ .no_executors_grace_period_seconds
+ .unwrap_or(opt.executor_timeout_seconds),
Review Comment:
Kept the default equal to executor_timeout_seconds rather than a multiple:
180s is already ~3× the 60s heartbeat. Increasing further might push total-loss
failures to 6+ min with multiples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
