milenkovicm commented on code in PR #2287: URL: https://github.com/apache/datafusion-ballista/pull/2287#discussion_r3764619805
########## docs/source/contributors-guide/architecture.md: ########## @@ -72,7 +72,7 @@ between the executor(s) and the scheduler for fetching tasks and reporting task The scheduler provides the following interfaces: - gRPC service for submitting and managing jobs -- Flight SQL API +- optional Arrow Flight proxy for fetching query results Review Comment: We do not need to advertise proxy, would suggest to remove if ########## docs/source/contributors-guide/code-organization.md: ########## @@ -46,9 +46,9 @@ This section provides links to the source code for major areas of functionality. ### ballista crate - [Crate Source](https://github.com/apache/datafusion-ballista/tree/main/ballista/client) -- [Context](https://github.com/apache/datafusion-ballista/blob/main/ballista/client/src/context.rs) +- [Context Extensions](https://github.com/apache/datafusion-ballista/blob/main/ballista/client/src/extension.rs) ### PyBallista - [Source](https://github.com/apache/datafusion-ballista/tree/main/python) -- [Context](https://github.com/apache/datafusion-ballista/blob/main/python/src/context.rs) +- [Context](https://github.com/apache/datafusion-ballista/blob/main/python/python/ballista/extension.py) Review Comment: I suggest to remove this line ########## docs/source/contributors-guide/code-organization.md: ########## @@ -33,7 +33,7 @@ This section provides links to the source code for major areas of functionality. - [Crate Source](https://github.com/apache/datafusion-ballista/tree/main/ballista/scheduler) - [Distributed Query Planner](https://github.com/apache/datafusion-ballista/blob/main/ballista/scheduler/src/planner.rs) - [gRPC Service](https://github.com/apache/datafusion-ballista/blob/main/ballista/scheduler/src/scheduler_server/grpc.rs) -- [Flight SQL Service](https://github.com/apache/datafusion-ballista/blob/main/ballista/scheduler/src/flight_sql.rs) +- [Flight Proxy Service](https://github.com/apache/datafusion-ballista/blob/main/ballista/scheduler/src/flight_proxy_service.rs) Review Comment: I don't think we need this line either -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
