alamb commented on code in PR #24279: URL: https://github.com/apache/datafusion/pull/24279#discussion_r3769247222
########## datafusion/proto-models/README.md: ########## @@ -22,9 +22,17 @@ [Apache DataFusion] is an extensible query execution framework, written in Rust, that uses [Apache Arrow] as its in-memory format. This crate contains the [prost]-generated Rust types for DataFusion's logical -and physical plan protobuf schemas. It is intentionally kept narrow: it has no -DataFusion dependencies beyond [`datafusion-proto-common`] and exposes only the -generated structs (and optional [pbjson]/[serde] support). +and physical plan protobuf schemas, plus the `From` / `TryFrom` conversions +between those types and the [`datafusion-common`] types they mirror. The +conversions live here because their DataFusion side sits _below_ this crate in +the dependency graph and so cannot host the impls itself — the same arrangement +[`datafusion-proto-common`] uses for `ScalarValue` and `Statistics`. Review Comment: I recommend adding a link to the relevant context / definition for ScaalrValue / Statistics as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
