sandeshkr419 commented on PR #23816: URL: https://github.com/apache/datafusion/pull/23816#issuecomment-5273610199
Thanks @kosiew for running the benchmarks again! The `decimal128/256` regression should now go away with my the latest commit. In the latest commit, I extracted `DEFAULT_Q` and `DEFAULT_MASK` as module-level constants (single declaration), and funnelled all pre-hashed loops through a `for_each_hash` method that checks `p == DEFAULT_HLL_P` once before entering the loop. The `Extend` impls still have an explicit and **intentional** `if self.p == DEFAULT_HLL_P` branch inline because Rust's compiler needs to see the const values at the call site to emit them as instruction immediates. A helper function boundary blocks that optimization (measured it: +10% regression when abstracted through map()). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
