haohuaijin commented on code in PR #24186:
URL: https://github.com/apache/datafusion/pull/24186#discussion_r3771876566
##########
datafusion/datasource-parquet/src/access_plan.rs:
##########
@@ -160,23 +162,77 @@ impl RowGroupAccess {
}
}
-/// Single-pass cursor over a file-level [`RowSelection`].
+/// Splits an overall selection into row groups in one pass.
Review Comment:
no, this is another case, related pr
https://github.com/apache/datafusion/pull/22940, before #22940 datafusion's
`ParquetAccessPlan` need `RowSelection` in the row-group level, the #22940
support the file level `RowSelection` and then split it into row-group level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
