Copilot commented on code in PR #2293: URL: https://github.com/apache/datafusion-ballista/pull/2293#discussion_r3776893615
########## docs/source/contributors-guide/development.md: ########## @@ -182,6 +182,29 @@ This includes instructions for: - Comparing performance with Apache Spark - Running load tests +## DataFusion dependency + +Between releases, `main` depends on a pinned git revision of +[`apache/datafusion`](https://github.com/apache/datafusion) `main` rather than a crates.io release, so +that breaking changes arrive in small increments instead of piling up at release time. + +The `datafusion*` entries in the workspace `Cargo.toml` move through one cycle per release: Review Comment: The new section states that between releases `main` depends on a pinned git revision of `apache/datafusion`, but the current workspace `Cargo.toml` uses crates.io versions for the `datafusion*` deps (e.g. `datafusion = "54"`). As written, this will confuse contributors because it describes behavior that isn’t reflected in the repo today. Consider making the wording conditional (i.e., explain what it means *when* `Cargo.toml` points at a git `rev`) rather than asserting it always does on `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
