jayzhan211 commented on code in PR #11969:
URL: https://github.com/apache/datafusion/pull/11969#discussion_r1718414338
##########
datafusion/sqllogictest/test_files/map.slt:
##########
@@ -493,3 +509,68 @@ select cardinality(map([1, 2, 3], ['a', 'b', 'c'])),
cardinality(MAP {'a': 1, 'b
cardinality(MAP {'a': MAP {1:'a', 2:'b', 3:'c'}, 'b': MAP {2:'c',
4:'d'} });
----
3 2 0 2
+
+# map_extract
+# key is string
+query IIII
+select map_extract(MAP {'a': 1, 'b': NULL, 'c': 3}, 'a'), map_extract(MAP
{'a': 1, 'b': NULL, 'c': 3}, 'b'),
+ map_extract(MAP {'a': 1, 'b': NULL, 'c': 3}, 'c'), map_extract(MAP
{'a': 1, 'b': NULL, 'c': 3}, 'd');
+----
+1 NULL 3 NULL
Review Comment:
I check the history of map_extract in duckdb and find that there is no
discussion about it. It is created by one man in early day
https://github.com/duckdb/duckdb/blob/a196a022ffcf427aa21184d295bb70caa42e0655/src/function/scalar/nested/map_extract.cpp
Given the rationale is not clear, I don't have strong opinion to strictly
follow what duckdb is in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
