Jefffrey commented on code in PR #24282:
URL: https://github.com/apache/datafusion/pull/24282#discussion_r3781426251
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -1118,6 +1117,22 @@ impl Coercion {
}
}
+ /// Create a new coercion to a native logical type with implicit coercion
rules.
+ ///
+ /// The native type of `desired_type` is used as the default type when
coercing
+ /// from `allowed_source_types`.
Review Comment:
could we add a note to this documentation to explain why one would prefer
using this over `new_implicit()`
e.g. "convenience method when coercing to a specific logical type"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
