alamb commented on code in PR #12001:
URL: https://github.com/apache/datafusion/pull/12001#discussion_r1718428682
##########
datafusion/expr-common/src/accumulator.rs:
##########
@@ -64,9 +64,6 @@ pub trait Accumulator: Send + Sync + Debug {
/// For example, the `SUM` accumulator maintains a running sum,
/// and `evaluate` will produce that running sum as its output.
///
- /// After this call, the accumulator's internal state should be
Review Comment:
I think it would be better update the docs to explain what the state can be
after calling the function rather than simply removing the docs.
For example, is it the case that
* "calling evaluate twice should result in an error"?
* "calling evaluate twice will result in potentially non deterministic
behavior"?
* Something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
