kosiew commented on code in PR #23987: URL: https://github.com/apache/datafusion/pull/23987#discussion_r3782654134
########## datafusion/spark/src/function/math/modulus.rs: ########## Review Comment: Nice work covering these cases for `mod`. Since `pmod` also reaches the updated `try_rem` helper twice, could we add similar coverage for that path too? It would be useful to include `pmod` SQLLogic or unit cases for ANSI float `0.0`, legacy `-0.0`, and ANSI `NULL % 0.0`. That should help make sure the second remainder path stays protected as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
