github-actions[bot] commented on PR #24055: URL: https://github.com/apache/datafusion/pull/24055#issuecomment-5292135440
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v54.1.0 (current) Built [ 43.120s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.137s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 38.803s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.145s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.728s] 223 checks: 215 pass, 8 fail, 0 warn, 31 skip --- failure declarative_macro_missing: macro_rules declaration removed or renamed --- Description: A `macro_rules!` declarative macro cannot be invoked by its prior name. The macro may have been renamed or removed entirely. ref: https://doc.rust-lang.org/reference/macros-by-example.html#path-based-scope impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/declarative_macro_missing.ron Failed in: macro validate_child_count, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:2033 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_missing.ron Failed in: enum datafusion_physical_plan::execution_plan::ChildrenPropertiesMode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1054 enum datafusion_physical_plan::ChildrenPropertiesMode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1054 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_physical_plan::execution_plan::replace_children_if_necessary, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1700 function datafusion_physical_plan::replace_children_if_necessary, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1700 --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_physical_plan::windows::get_best_fitting_window now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/windows/mod.rs:592 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: BoundedWindowAggExec::with_state_observer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs:223 BoundedWindowAggExec::state_observer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs:249 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_physical_plan::repartition::RangeExpr, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/repartition/mod.rs:657 struct datafusion_physical_plan::execution_plan::ReplaceChildrenOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1035 struct datafusion_physical_plan::ReplaceChildrenOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1035 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron Failed in: method replace_children of trait ExecutionPlan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:276 method replace_children of trait ExecutionPlan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:276 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_missing.ron Failed in: trait datafusion_physical_plan::execution_plan::AsPhysicalExprRef, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1067 trait datafusion_physical_plan::AsPhysicalExprRef, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/execution_plan.rs:1067 trait datafusion_physical_plan::windows::WindowStateObserver, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/f6ed3e6a7dab325ea6e031f0076cfa529396cf39/datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs:92 Summary semver requires new major version: 8 major and 0 minor checks failed Finished [ 84.291s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
