alamb opened a new pull request, #24362: URL: https://github.com/apache/datafusion/pull/24362
## Which issue does this PR close? - Follow on to https://github.com/apache/datafusion/pull/24325 ## Rationale for this change @Dandandan came up with a very clever way to improve compile time, see https://github.com/apache/datafusion/issues/13814#issuecomment-5281799225 However, the workaround (to make a special future and implement the async trait manually) is not obvious (at least to me) and I worry it might get removed in the future by accident, as we don't have any checks to prevent the regression Thus I think some comments explaining the pattern and how it would work will help avoid such a problem ## What changes are included in this PR? Add comments explaining why the code is done this way ## Are these changes tested? Comments only ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
