LDM-A commented on PR #24103: URL: https://github.com/apache/datafusion/pull/24103#issuecomment-5294693524
> @LDM-A, > > Thanks for working on this. I like the direction of distinguishing nullable UNIQUE dependencies and using ANY_VALUE for dependent columns. I found one correctness issue that I think needs to be addressed before this is ready. > > The duplicate-NULL restriction needs to apply consistently to every functional dependency consumer, not just GROUP BY target expansion. I left the details inline, along with one non-blocking test suggestion. Thank you for your review. I will look into your comments a little later and make the needed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
