ntjohnson1 commented on code in PR #1677:
URL:
https://github.com/apache/datafusion-python/pull/1677#discussion_r3786169274
##########
python/datafusion/context.py:
##########
@@ -1759,6 +1769,36 @@ def add_physical_optimizer_rule(
"""
self.ctx.add_physical_optimizer_rule(rule)
+ def with_query_planner(
Review Comment:
Generally wonder if this builder pattern feels pythonic. Consistent with
what's already here so no action requested. Didn't look at how many withs there
are but
```python
ctx = SessionContext(config, planner)
```
feels a little more intuitive than
```python
ctx = SessionContext().with_query_planner(planner)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
