Kimahriman commented on code in PR #832: URL: https://github.com/apache/datafusion-comet/pull/832#discussion_r1718513726
########## common/src/main/scala/org/apache/comet/CometConf.scala: ########## @@ -441,20 +459,20 @@ object CometConf extends ShimCometConf { .booleanConf .createWithDefault(COMET_SCHEMA_EVOLUTION_ENABLED_DEFAULT) - val COMET_SPARK_TO_COLUMNAR_ENABLED: ConfigEntry[Boolean] = + val COMET_SPARK_TO_ARROW_ENABLED: ConfigEntry[Boolean] = conf("spark.comet.sparkToColumnar.enabled") Review Comment: Do you prefer that name/should we update the config to sparkToArrow while we're making these updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org