shinzoxD commented on issue #17498: URL: https://github.com/apache/datafusion/issues/17498#issuecomment-5304216763
I'd like to take a slice of this: validate `datafusion.sql_parser.default_null_ordering` at SET time. That option is still a raw string, so values like `nuls_max` (or an empty string) are accepted and then silently treated as `nulls_max` via `NullOrdering`'s `From<&str>` fallback. I'll turn it into a typed config enum in the same style as `explain.format` / `sql_parser.dialect`, reject invalid values immediately, and keep the four documented options (`nulls_max`, `nulls_min`, `nulls_first`, `nulls_last`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
