andygrove commented on PR #2315: URL: https://github.com/apache/datafusion-ballista/pull/2315#issuecomment-5308644923
Tried this PR on our EKS cluster running TPC-H SF1000 (parquet/zstd, 32 executors × 8 concurrent tasks, 2 iterations per query). AQE default-on as this PR flips it. **Total wall time: 632.7s** vs 721.7s on our most recent baseline before this PR (same cluster, same config) — **~12% faster overall**. **Q11 now passes** (15.2s). It was erroring on every prior run for us, so the AQE plan-rewrite fix here appears to resolve it directly. **Per-query deltas vs baseline** (bold = >10% change): | Query | Baseline (s) | PR #2315 (s) | Δ | |---|---:|---:|---:| | Q1 | 21.7 | 14.5 | **−33%** | | Q2 | 26.7 | 35.8 | **+34%** | | Q3 | 34.8 | 33.2 | −4% | | Q4 | 20.7 | 19.8 | −5% | | Q5 | 42.3 | 46.5 | **+10%** | | Q6 | 13.8 | 9.5 | **−31%** | | Q7 | 47.2 | 48.0 | +2% | | Q8 | 45.7 | 54.2 | **+19%** | | Q9 | 67.3 | 79.3 | **+18%** | | Q10 | 53.0 | ERR | regressed | | Q11 | ERR | 15.2 | **fixed** | | Q12 | 26.0 | 15.9 | **−39%** | | Q13 | 15.3 | 13.9 | −10% | | Q14 | 21.1 | 12.8 | **−39%** | | Q15 | 27.3 | 23.7 | **−13%** | | Q16 | 17.4 | 12.4 | **−29%** | | Q17 | 47.3 | 33.0 | **−30%** | | Q18 | 78.3 | 51.8 | **−34%** | | Q19 | 18.7 | 15.2 | **−19%** | | Q20 | 97.1 | 98.0 | +1% | **New failure — Q10:** \`\`\` Job failed due to stage 6 failed: Task failed due to runtime execution error: DataFusionError(Shared(External(... \`\`\` Our runner was truncating errors at 200 chars so the root cause is cut off. I've fixed that and will re-run Q10 with \`EXPLAIN ANALYZE\` to get a real trace. Q21 and Q22 also errored, but they fail on every recent run for us with connection/h2 errors unrelated to this PR — likely a cluster-side scheduler issue at end-of-run. Not counting them against this PR. Net: strong overall win, one query fixed, one query regressed with cause still to be identified. I'll follow up with the Q10 trace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
