kosiew commented on code in PR #24142:
URL: https://github.com/apache/datafusion/pull/24142#discussion_r3794319933
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -2725,6 +2752,48 @@ mod tests {
check_join_set_is_valid(&left, &right, on)
}
+ #[test]
+ fn build_probe_join_metrics_elapsed_compute_not_double_counted_on_clone() {
Review Comment:
Nice regression test. One additional test that might be worth considering is
an execution-level `HashJoinExec` test where the build stream yields before
completing. This unit test covers the shared-finalizer ownership behavior well,
while an execution-level test would also exercise the `HashJoinExec::execute`
clone and future wiring that originally exposed the issue. Not blocking for
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
