amitvijapur commented on PR #24409: URL: https://github.com/apache/datafusion/pull/24409#issuecomment-5313933644
Noting the overlap for reviewers: #23898 touches the same two files. That PR corrects `pmod`'s *runtime* behaviour — Java-style integer overflow on `(r + n) % n`, ANSI-mode zero divisors for floating point, and `-0.0` handling. This PR corrects its *declared result type*, and is the only one of the two to touch `Signature`, `coerce_types` or `return_type`. So they are complementary rather than competing, but they will conflict textually in both `modulus.rs` and `pmod.slt`. Happy to rebase this one on top of #23898 if that lands first, or to hold if you would rather they were sequenced the other way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
